-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: Include candidate type and MC pubkey in committee data in the storage #506
Merged
+479
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmbientTea
commented
Feb 19, 2025
AmbientTea
commented
Feb 19, 2025
LGLO
reviewed
Feb 19, 2025
LGLO
reviewed
Feb 19, 2025
cb14333
to
1c22d64
Compare
dd780c1
to
f3b3031
Compare
AmbientTea
commented
Feb 20, 2025
toolkit/pallets/session-validator-management/src/migrations/v1.rs
Outdated
Show resolved
Hide resolved
LGLO
reviewed
Feb 20, 2025
LGLO
reviewed
Feb 20, 2025
LGLO
reviewed
Feb 20, 2025
LGLO
reviewed
Feb 20, 2025
LGLO
reviewed
Feb 20, 2025
toolkit/pallets/session-validator-management/benchmarking/src/lib.rs
Outdated
Show resolved
Hide resolved
e90921b
to
d347fa4
Compare
LGLO
reviewed
Feb 21, 2025
LGLO
reviewed
Feb 21, 2025
e0423cb
to
529b22d
Compare
6 tasks
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
b995be9
to
3183402
Compare
LGLO
approved these changes
Feb 21, 2025
faeb3a6
to
342ebbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IMPORTANT: This is a breaking change and must not be merged without a storage migration ready.
This PR's goal is to make previously missing committee member data available in the runtime: MC pubkey and type of candidate (permissioned, trustless)
pallet-session-validator-management::Config
CommitteeMemberInfo
enum in the runtime to instantiate this generic type, which distinguishes between trustless and permissioned members and contains MC Public Key for the formerFollow up changes necessary:
Checklist
changelog.md
for affected crateNote on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.