Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Include candidate type and MC pubkey in committee data in the storage #506

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

AmbientTea
Copy link
Contributor

@AmbientTea AmbientTea commented Feb 19, 2025

Description

IMPORTANT: This is a breaking change and must not be merged without a storage migration ready.

This PR's goal is to make previously missing committee member data available in the runtime: MC pubkey and type of candidate (permissioned, trustless)

  • Makes committee member data a generic type in pallet-session-validator-management::Config
  • Provides a CommitteeMemberInfo enum in the runtime to instantiate this generic type, which distinguishes between trustless and permissioned members and contains MC Public Key for the former

Follow up changes necessary:

  • storage migration: easiest way is to treat all members stored on runtime upgrade as permissioned
  • wizards update: at least build-spec
  • documentation / migration guide

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@AmbientTea AmbientTea changed the base branch from master to differentiate-candidate-types February 19, 2025 13:58
@AmbientTea AmbientTea requested review from Klapeyron, LGLO and gilligan and removed request for Klapeyron February 19, 2025 14:01
@AmbientTea AmbientTea force-pushed the differentiate-candidate-types-2 branch from cb14333 to 1c22d64 Compare February 19, 2025 15:50
Base automatically changed from differentiate-candidate-types to master February 20, 2025 08:55
@AmbientTea AmbientTea force-pushed the differentiate-candidate-types-2 branch 2 times, most recently from dd780c1 to f3b3031 Compare February 20, 2025 12:59
@AmbientTea AmbientTea changed the title change: Differentiate candidate types 2 change: Include candidate type and MC pubkey in committee data in the storage Feb 20, 2025
@AmbientTea AmbientTea marked this pull request as ready for review February 20, 2025 13:50
@AmbientTea AmbientTea force-pushed the differentiate-candidate-types-2 branch 2 times, most recently from e90921b to d347fa4 Compare February 20, 2025 16:58
@AmbientTea AmbientTea force-pushed the differentiate-candidate-types-2 branch 3 times, most recently from e0423cb to 529b22d Compare February 21, 2025 12:36
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
@AmbientTea AmbientTea force-pushed the differentiate-candidate-types-2 branch from b995be9 to 3183402 Compare February 21, 2025 15:19
@AmbientTea AmbientTea force-pushed the differentiate-candidate-types-2 branch from faeb3a6 to 342ebbc Compare February 21, 2025 16:15
@AmbientTea AmbientTea enabled auto-merge (squash) February 21, 2025 16:29
@AmbientTea AmbientTea merged commit 502f9f4 into master Feb 21, 2025
23 checks passed
@AmbientTea AmbientTea deleted the differentiate-candidate-types-2 branch February 21, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants